Skip to content

Conversation

@sbomer
Copy link
Member

@sbomer sbomer commented Sep 6, 2023

I think these are unnecessary. I noticed the eventpipe test build produces a warning about a duplicate import of liveBuilds.targets, which is already imported by src/tests/Directory.Build.targets.

@ghost ghost assigned sbomer Sep 6, 2023
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 6, 2023
@sbomer sbomer marked this pull request as ready for review September 8, 2023 16:50
@ViktorHofer
Copy link
Member

I don't think I'm the right person to review this change. Don't know enough about this source tree.

@ViktorHofer ViktorHofer removed their request for review September 8, 2023 16:53
Copy link
Contributor

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbomer sbomer merged commit f75057f into dotnet:main Sep 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2023
@sbomer sbomer deleted the fixImport branch November 3, 2023 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants